rfc(dm): add rfc for continuous data validation #6391
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
removed
the
do-not-merge/work-in-progress
Co-authored-by: Obliviate <[email protected]>
| - TiDB implements floating point data types differently with MySQL, we take it as equal if its absolute difference < 10^-6 | ||
| - do not support validation for JSON and binary data types | ||
|
|
||
| ## Detailed Design |
There was a problem hiding this comment.
its name is "Detailed" design, I expect there should also exist "brief" introduction
There was a problem hiding this comment.
it's from google doc template
|
|
||
| Validator `worker` will cache `pending row changes` in memory, to avoid potential OOM, we add an self-protect mechaniam. If there's too much `pending row changes` or the overall size of `pending row changes` is too large, validator will be stopped automatically. | ||
|
|
||
| ## Concepts |
There was a problem hiding this comment.
| ## Concepts | |
| ## Glossary |
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: Obliviate <[email protected]>
Co-authored-by: lance6716 <[email protected]>
Co-authored-by: lance6716 <[email protected]>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5b9b255
|
ti-chi-bot
added
the
status/can-merge
|
@D3Hunter: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-dm-integration-test |
| - do not support validation for tasks which enable extend-column | ||
| - do not support validation for tasks which enable event filtering by expression | ||
| - TiDB implements floating point data types differently with MySQL, we take it as equal if its absolute difference < 10^-6 | ||
| - do not support validation for JSON and binary data types |
There was a problem hiding this comment.
is there a workaround for binary data type?
What problem does this PR solve?
Issue Number: ref #4426
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note