Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(ticdc): fix update resolved ts not taking effect issue #6118

Merged

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

  • delete buffer after flush
  • set correct eventID
  • add more tests

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 29, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 29, 2022
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Jun 29, 2022
@Rustin170506
Copy link
Member Author

/run-verify

@Rustin170506 Rustin170506 requested review from sdojjy and asddongmen and removed request for sdojjy June 30, 2022 02:32
@Rustin170506 Rustin170506 requested a review from asddongmen June 30, 2022 09:29
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2022
@hicqu
Copy link
Contributor

hicqu commented Jul 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@hicqu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a94d4c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2022
@Rustin170506
Copy link
Member Author

/run-verify

@codecov-commenter
Copy link

Codecov Report

Merging #6118 (f4c8145) into master (792faf7) will decrease coverage by 0.7427%.
The diff coverage is 68.8918%.

Flag Coverage Δ
cdc 63.5760% <77.1739%> (-1.6309%) ⬇️
dm 51.8553% <43.1034%> (-0.0685%) ⬇️
engine 62.7302% <75.8454%> (+0.0990%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6118        +/-   ##
================================================
- Coverage   58.6479%   57.9052%   -0.7428%     
================================================
  Files           711        701        -10     
  Lines         83933      83141       -792     
================================================
- Hits          49225      48143      -1082     
- Misses        30258      30646       +388     
+ Partials       4450       4352        -98     

@ti-chi-bot ti-chi-bot merged commit 187b402 into pingcap:master Jul 1, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sinkv2-event-table-sink branch July 1, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants