-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinkv2(ticdc): fix update resolved ts not taking effect issue #6118
sinkv2(ticdc): fix update resolved ts not taking effect issue #6118
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-verify |
/merge |
@hicqu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a94d4c3
|
/run-verify |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6118 +/- ##
================================================
- Coverage 58.6479% 57.9052% -0.7428%
================================================
Files 711 701 -10
Lines 83933 83141 -792
================================================
- Hits 49225 48143 -1082
- Misses 30258 30646 +388
+ Partials 4450 4352 -98 |
What problem does this PR solve?
Issue Number: ref #5928
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note