-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinkv2(ticdc): impl TxnEventAppender and add tests #6109
sinkv2(ticdc): impl TxnEventAppender and add tests #6109
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self check
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6109 +/- ##
================================================
+ Coverage 57.7148% 57.7531% +0.0382%
================================================
Files 699 700 +1
Lines 82743 82470 -273
================================================
- Hits 47755 47629 -126
+ Misses 30637 30507 -130
+ Partials 4351 4334 -17 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 51192af
|
What problem does this PR solve?
Issue Number: ref #5928
What is changed and how it works?
impl TxnEventAppender and add tests.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note