Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(ticdc): impl TxnEventAppender and add tests #6109

Merged
merged 6 commits into from
Jun 29, 2022

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

impl TxnEventAppender and add tests.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2022
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self check

cdc/sinkv2/eventsink/event_appender.go Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #6109 (491089b) into master (5c5c5a5) will increase coverage by 0.0382%.
The diff coverage is 71.6895%.

❗ Current head 491089b differs from pull request most recent head 5e2b39f. Consider uploading reports for the commit 5e2b39f to get more accurate results

Flag Coverage Δ
cdc 63.2565% <79.5620%> (+0.1110%) ⬆️
dm 51.9508% <100.0000%> (+0.0306%) ⬆️
engine 62.4577% <56.9620%> (-0.0224%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6109        +/-   ##
================================================
+ Coverage   57.7148%   57.7531%   +0.0382%     
================================================
  Files           699        700         +1     
  Lines         82743      82470       -273     
================================================
- Hits          47755      47629       -126     
+ Misses        30637      30507       -130     
+ Partials       4351       4334        -17     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51192af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2022
@ti-chi-bot ti-chi-bot merged commit 18e40b5 into pingcap:master Jun 29, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sinkv2-appender branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants