sinkv2(ticdc): add interfaces #6017

Rustin170506 · 2022-06-23T15:08:27Z

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

Add interfaces

Check List

Tests

No need

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

ti-chi-bot · 2022-06-23T15:08:28Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

asddongmen
nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lonng

Please remove the following files:

cdc/sinkv2/ddlsink/mq/.keep
cdc/sinkv2/ddlsink/mysql/.keep

cdc/sinkv2/event/event.go

cdc/sinkv2/event/row_change_event_appender.go

nongfushanquan · 2022-06-24T01:13:59Z

cdc/sinkv2/tablesink/event_table_sink.go

+		return
+	}
+	resolvedEvents := e.eventBuffer[:i]
+


what is the relationship between the event and the txnevent?

event can be txnevent or rowchangeevent

// Assert TableSink implementation var _ TableSink = (*eventTableSink[*model.RowChangedEvent])(nil) var _ TableSink = (*eventTableSink[*model.SingleTableTxn])(nil)

Rustin170506 · 2022-06-24T02:33:53Z

Please remove the following files:
cdc/sinkv2/ddlsink/mq/.keep
cdc/sinkv2/ddlsink/mysql/.keep

Want to rely on these files to agree on package directories.

codecov-commenter · 2022-06-24T03:09:10Z

Codecov Report

Merging #6017 (f58d752) into master (b1ce2c9) will increase coverage by 0.3382%.
The diff coverage is 66.4124%.

Flag	Coverage Δ
cdc	`62.9696% <69.8265%> (+0.5927%)`	⬆️
dm	`51.9405% <35.5555%> (-0.0325%)`	⬇️
engine	`62.3076% <35.6756%> (-0.1329%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6017        +/-   ##
================================================
+ Coverage   57.2815%   57.6198%   +0.3382%     
================================================
  Files           680        696        +16     
  Lines         80230      82515      +2285     
================================================
+ Hits          45957      47545      +1588     
- Misses        30009      30634       +625     
- Partials       4264       4336        +72

Rustin170506

self check

cdc/sinkv2/tablesink/event_table_sink.go

cdc/sinkv2/tablesink/progress_tracker.go

cdc/sinkv2/tablesink/event_table_sink.go

hicqu · 2022-06-27T09:29:10Z

/LGTM

Rustin170506 · 2022-06-27T10:08:28Z

/merge

ti-chi-bot · 2022-06-27T10:08:30Z

This pull request has been accepted and is ready to merge.

Commit hash: 7695a55

Rustin170506

Self check

Rustin170506 · 2022-06-27T10:36:57Z

/run-dm-integration-test

ti-chi-bot · 2022-06-27T11:44:51Z

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Rustin170506 · 2022-06-27T12:12:27Z

/run-dm-integration-test

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2022

lonng reviewed Jun 23, 2022

View reviewed changes

cdc/sinkv2/event/event.go Outdated Show resolved Hide resolved

nongfushanquan reviewed Jun 24, 2022

View reviewed changes

cdc/sinkv2/event/row_change_event_appender.go Outdated Show resolved Hide resolved

nongfushanquan reviewed Jun 24, 2022

View reviewed changes

Rustin170506 mentioned this pull request Jun 24, 2022

sinkv2(ticdc): add interfaces #5929

Closed

Rustin170506 force-pushed the rustin-patch-sinkv2-generic branch from 60f9efc to 25b13bd Compare June 24, 2022 02:35

Rustin170506 requested review from lonng and nongfushanquan June 24, 2022 02:35

Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Jun 24, 2022

Rustin170506 requested a review from CharlesCheung96 June 24, 2022 02:36

Rustin170506 force-pushed the rustin-patch-sinkv2-generic branch from 29ae08c to 9bad97e Compare June 24, 2022 02:50

asddongmen self-requested a review June 24, 2022 03:30

Rustin170506 commented Jun 24, 2022

View reviewed changes

Rustin170506 changed the title ~~sinkv2(ticdc): add interfaces [generic version]~~ sinkv2(ticdc): add interfaces Jun 25, 2022

Rustin170506 added 4 commits June 26, 2022 16:20

sinkv2(ticdc): add interfaces

ad3b452

sinkv2(ticdc): add interfaces [generic version]

b4bca8f

sinkv2(ticdc): fix append

914eda9

sinkv2(ticdc): add status and close it

f109449

Rustin170506 force-pushed the rustin-patch-sinkv2-generic branch from ff0bf0d to f109449 Compare June 26, 2022 08:35

nongfushanquan approved these changes Jun 27, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 27, 2022

nongfushanquan reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/event_table_sink.go Outdated Show resolved Hide resolved

lonng reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/event_table_sink.go Show resolved Hide resolved

hicqu reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/progress_tracker.go Outdated Show resolved Hide resolved

Rustin170506 added 2 commits June 27, 2022 14:10

sinkv2(ticdc): fix advance bug

721f2d1

sinkv2(ticdc): fix advance bug

f58d752

Rustin170506 requested review from hicqu and lonng June 27, 2022 06:18

CharlesCheung96 reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/event_table_sink.go Outdated Show resolved Hide resolved

Rustin170506 requested a review from CharlesCheung96 June 27, 2022 08:47

CharlesCheung96 reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/event_table_sink.go Outdated Show resolved Hide resolved

sinkv2(ticdc): rename

4dffbb7

CharlesCheung96 reviewed Jun 27, 2022

View reviewed changes

cdc/sinkv2/tablesink/event_table_sink.go Show resolved Hide resolved

asddongmen approved these changes Jun 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 27, 2022

sinkv2(ticdc): move tableevent into eventsink

5f91acc

sinkv2(ticdc): split event appender

7695a55

Rustin170506 requested a review from CharlesCheung96 June 27, 2022 09:43

CharlesCheung96 approved these changes Jun 27, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2022

Merge branch 'master' into rustin-patch-sinkv2-generic

7e9a106

Rustin170506 commented Jun 27, 2022

View reviewed changes

ti-chi-bot added 3 commits June 27, 2022 18:42

Merge branch 'master' into rustin-patch-sinkv2-generic

cfb6836

Merge branch 'master' into rustin-patch-sinkv2-generic

8f65c01

Merge branch 'master' into rustin-patch-sinkv2-generic

8e35041

ti-chi-bot merged commit e4bab46 into pingcap:master Jun 27, 2022

Rustin170506 deleted the rustin-patch-sinkv2-generic branch June 27, 2022 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sinkv2(ticdc): add interfaces #6017

sinkv2(ticdc): add interfaces #6017

Rustin170506 commented Jun 23, 2022 •

edited

Loading

ti-chi-bot commented Jun 23, 2022 •

edited

Loading

lonng left a comment

nongfushanquan Jun 24, 2022

Rustin170506 Jun 24, 2022

Rustin170506 Jun 24, 2022

Rustin170506 commented Jun 24, 2022

codecov-commenter commented Jun 24, 2022 •

edited

Loading

Rustin170506 left a comment

hicqu commented Jun 27, 2022

Rustin170506 commented Jun 27, 2022

ti-chi-bot commented Jun 27, 2022

Rustin170506 left a comment

Rustin170506 commented Jun 27, 2022

ti-chi-bot commented Jun 27, 2022

Rustin170506 commented Jun 27, 2022

sinkv2(ticdc): add interfaces #6017

sinkv2(ticdc): add interfaces #6017

Conversation

Rustin170506 commented Jun 23, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

ti-chi-bot commented Jun 23, 2022 • edited Loading

lonng left a comment

Choose a reason for hiding this comment

nongfushanquan Jun 24, 2022

Choose a reason for hiding this comment

Rustin170506 Jun 24, 2022

Choose a reason for hiding this comment

Rustin170506 Jun 24, 2022

Choose a reason for hiding this comment

Rustin170506 commented Jun 24, 2022

codecov-commenter commented Jun 24, 2022 • edited Loading

Codecov Report

Rustin170506 left a comment

Choose a reason for hiding this comment

hicqu commented Jun 27, 2022

Rustin170506 commented Jun 27, 2022

ti-chi-bot commented Jun 27, 2022

Rustin170506 left a comment

Choose a reason for hiding this comment

Rustin170506 commented Jun 27, 2022

ti-chi-bot commented Jun 27, 2022

Rustin170506 commented Jun 27, 2022

Rustin170506 commented Jun 23, 2022 •

edited

Loading

ti-chi-bot commented Jun 23, 2022 •

edited

Loading

codecov-commenter commented Jun 24, 2022 •

edited

Loading