Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cdc): Migrate tidb mysql test to ticdc(part2) #5087

Closed
wants to merge 9 commits into from
Closed

test(cdc): Migrate tidb mysql test to ticdc(part2) #5087

wants to merge 9 commits into from

Conversation

maxshuang
Copy link
Contributor

@maxshuang maxshuang commented Mar 31, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5081

migrate follow test cases to ticdc:

bigint composite_index date_formats datetime_insert 
datetime_update drop concurrent_ddl gcol_alter_table 
partition_bug18198 update_stmt alter_table alter_table_PK
partition_list partition_range single_delete_update time 
timestamp_insert timestamp_update type_decimal transaction_isolation_func
type_time type_timestamp type_uint update 
insert_select insert_update alter_table1 json
mysql_replace date_time_ddl"

What is changed and how it works?

  1. using tidb-test as submodule of ticdc
  2. provide a script to convert tidb mysql test case to achieve e2e test automatically
`None`.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 31, 2022
@maxshuang maxshuang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@maxshuang maxshuang requested review from overvenus, Rustin170506 and amyangfei and removed request for overvenus March 31, 2022 16:52
@maxshuang
Copy link
Contributor Author

hold this pr until jenken support git submodule operation and trigger integration test for it

@maxshuang maxshuang mentioned this pull request Apr 1, 2022
Closed
@purelind
Copy link
Collaborator

/run-integration-test

@maxshuang maxshuang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2022
@maxshuang
Copy link
Contributor Author

/run-integration-test

5 similar comments
@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/area ticdc

@ti-chi-bot ti-chi-bot added the area/ticdc Issues or PRs related to TiCDC. label Jun 30, 2022
@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang maxshuang changed the title Migrate tidb mysql test to ticdc(part2) test(cdc): Migrate tidb mysql test to ticdc(part2) Jun 30, 2022
@maxshuang
Copy link
Contributor Author

/run-integration-test

@maxshuang
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #5087 (fd0c594) into master (792faf7) will decrease coverage by 0.7006%.
Report is 1456 commits behind head on master.
The diff coverage is 64.2187%.

Additional details and impacted files
Flag Coverage Δ
cdc 63.3016% <71.0424%> (-1.9053%) ⬇️
dm 51.9085% <43.1034%> (-0.0153%) ⬇️
engine 63.8645% <73.4299%> (+1.2333%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5087        +/-   ##
================================================
- Coverage   58.6479%   57.9474%   -0.7006%     
================================================
  Files           711        701        -10     
  Lines         83933      82851      -1082     
================================================
- Hits          49225      48010      -1215     
- Misses        30258      30484       +226     
+ Partials       4450       4357        -93

@maxshuang maxshuang closed this by deleting the head repository Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate tidb mysql test to ticdc(part2)
3 participants
@maxshuang @ti-chi-bot @purelind