*(both): update dep of etcd, go-mysql and others #4755
Conversation
Signed-off-by: lance6716 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/check-issue-triage-complete |
|
/run-all-tests |
Signed-off-by: lance6716 <[email protected]>
| // cloud.google.com/go/storage will upgrade grpc to v1.40.0 | ||
| // we need keep the replacement until go.etcd.io supports the higher version of grpc. | ||
| google.golang.org/grpc v1.40.0 => google.golang.org/grpc v1.29.1 |
There was a problem hiding this comment.
Why we need to pin grpc to v1.29.1 before this PR
There was a problem hiding this comment.
introduced in #2833 @maxshuang PTAL
There was a problem hiding this comment.
grpc has directory changes, old etcd cannot use newer grpc.
| go.etcd.io/etcd/api/v3 v3.5.2 | ||
| go.etcd.io/etcd/client/pkg/v3 v3.5.2 | ||
| go.etcd.io/etcd/client/v3 v3.5.2 | ||
| go.etcd.io/etcd/pkg/v3 v3.5.2 | ||
| go.etcd.io/etcd/server/v3 v3.5.2 | ||
| go.etcd.io/etcd/tests/v3 v3.5.2 |
There was a problem hiding this comment.
@disksing has updated all active repos but forgotten us 😭
There was a problem hiding this comment.
pd/server uses old version but pd/client (and also client-go/tidb) uses v3.5.2
pingcap/tidb#32457 TiDB doesn't cherry-pick |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
|
/run-kafka-integration-test |
|
/run-leak-test |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
Signed-off-by: lance6716 <[email protected]>
|
/run-all-tests |
|
/run-integration-test /tikv=pr/12050 |
|
/run-all-tests all tests (except for CDC's broken CI) should have passed now, PTAL @amyangfei @overvenus @hi-rustin |
|
CDC's CI have benn passed before, I think it's OK to review now https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_kafka_integration_test/detail/cdc_ghpr_kafka_integration_test/9387/pipeline/ |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f74cd61
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-test |
|
/run-kafka-integration-test |
|
waiting #4783 to fix CI |
|
/merge |
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-verify |
Signed-off-by: lance6716 [email protected]
What problem does this PR solve?
Issue Number: ref #4418
What is changed and how it works?
main purpose is
Updating tidb-tools need updating etcd, and further need update many places
Check List
Tests
Code changes
Side effects
Related changes
Release note