Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker(dm): respect CHARSET when build TableInfo (#4638) #4646

Merged
merged 4 commits into from
Feb 28, 2022
+43 −5
Merged

tracker(dm): respect CHARSET when build TableInfo (#4638) #4646

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b39407
tracker(dm): respect CHARSET when build TableInfo
lance6716 Feb 21, 2022
72bb3f8
set valid status (seem don't set is also OK)
lance6716 Feb 21, 2022
7a69e15
address comment
lance6716 Feb 21, 2022
d89ac1a
Merge branch 'release-5.4' into cherry-pick-4638-to-release-5.4
ti-chi-bot Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set valid status (seem don't set is also OK)
@lance6716 @ti-chi-bot
lance6716 authored and ti-chi-bot committed Feb 21, 2022
commit 72bb3f8183c0929201d87be54235b39b99177bc3
1 change: 1 addition & 0 deletions dm/pkg/schema/tracker.go
View file
Original file line number Diff line number Diff line change
@@ -464,6 +464,7 @@ func (tr *Tracker) getTableInfoByCreateStmt(tctx *tcontext.Context, tableID stri
if err != nil {
return nil, dmterror.ErrSchemaTrackerCannotMockDownstreamTable.Delegate(err, createStr)
}
ti.State = model.StatePublic
return ti, nil
}