Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracker(dm): respect CHARSET when build TableInfo #4638

Merged
merged 5 commits into from
Feb 21, 2022
Merged

tracker(dm): respect CHARSET when build TableInfo #4638

merged 5 commits into from
Feb 21, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #4637

What is changed and how it works?

found that MockTableInfo will always use default charset and collation, BuildTableInfoFromAST is better

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix a bug that long varchar will report error of "Column length too big..."

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 21, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Feb 21, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2022
@lance6716 lance6716 requested a review from D3Hunter February 21, 2022 09:41
@lance6716 lance6716 added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Feb 21, 2022
lichunzhu
lichunzhu approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2022
@D3Hunter
Copy link
Contributor

/run-all-tests

WizardXiao
WizardXiao approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@WizardXiao WizardXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fb0b4f0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit efc0658 into pingcap:master Feb 21, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 21, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4645.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 21, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4646.

ti-chi-bot added a commit that referenced this pull request Feb 22, 2022
@ti-chi-bot
tracker(dm): respect CHARSET when build TableInfo (#4638) (#4645)
122ac4c 
close #4637
ti-chi-bot added a commit that referenced this pull request Feb 28, 2022
@ti-chi-bot
tracker(dm): respect CHARSET when build TableInfo (#4638) (#4646)
7defc78 
close #4637
@lance6716 lance6716 deleted the fix-varchar2000 branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WizardXiao WizardXiao WizardXiao approved these changes

@okJiang okJiang okJiang approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@Ehco1996 Ehco1996 Awaiting requested review from Ehco1996

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@lance6716 @ti-chi-bot @D3Hunter @lichunzhu @okJiang @WizardXiao