Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(ticdc): correctly handle the state after the old owner is upgraded to the new owner #3839

Closed
wants to merge 1 commit into from

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

part of #3473

What is changed and how it works?

correctly handle the state after the old owner is upgraded to the new owner.
Fix it in changefeed manager tick.

Check List

Tests

  • Unit test
  • Manual test (TBD)

Code changes

  • Has exported function/method change

Side effects

None

Related changes

None

Release note

Please add a release note.
Fix the problem of changefeed resuming automatically after upgrading cluster

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 11, 2021
@ti-chi-bot
Copy link
Member

@hi-rustin: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3839 (ab4eb50) into release-4.0 (753073a) will increase coverage by 3.3269%.
The diff coverage is 67.0512%.

@@                 Coverage Diff                 @@
##           release-4.0      #3839        +/-   ##
===================================================
+ Coverage      53.7661%   57.0930%   +3.3269%     
===================================================
  Files              153        170        +17     
  Lines            15958      19794      +3836     
===================================================
+ Hits              8580      11301      +2721     
- Misses            6475       7438       +963     
- Partials           903       1055       +152     

@Rustin170506
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants