Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient(ticdc): fix kvclient takes too long time to recover (#3612) #3662

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kvclient(ticdc): fix cherrypick conflict
maxshuang authored Dec 9, 2021
commit 899384395ef13c8b194915946547786ade4c7ba4
7 changes: 0 additions & 7 deletions cdc/kv/client_test.go
Original file line number Diff line number Diff line change
@@ -1660,16 +1660,9 @@ func (s *etcdSuite) TestIncompatibleTiKV(c *check.C) {
isPullInit := &mockPullerInit{}
grpcPool := NewGrpcPoolImpl(ctx, &security.Credential{})
defer grpcPool.Close()
<<<<<<< HEAD
cdcClient := NewCDCClient(ctx, pdClient, kvStorage, grpcPool)
eventCh := make(chan model.RegionFeedEvent, 10)
=======
regionCache := tikv.NewRegionCache(pdClient)
defer regionCache.Close()
cdcClient := NewCDCClient(ctx, pdClient, kvStorage, grpcPool, regionCache)
// NOTICE: eventCh may block the main logic of EventFeed
eventCh := make(chan model.RegionFeedEvent, 128)
>>>>>>> 82c4d68de (kvclient(ticdc): fix kvclient takes too long time to recover (#3612))
wg.Add(1)
go func() {
defer wg.Done()