Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) #3555

Merged
merged 2 commits into from
Nov 23, 2021
Merged

ticdc/metrics: fix processor checkpoint-ts lag expr (#3543) #3555

merged 2 commits into from
Nov 23, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3543

What problem does this PR solve?

Fix a metric expr

It is not reasonable if all captures checkpoint lag is low, but the checkpoint lag of changefeed is large

image

What is changed and how it works?

Use correct metric expr

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    After fix

image

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Nov 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2021
Merged
@ti-chi-bot ti-chi-bot added component/metrics-logging Metrics and logging component. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Nov 22, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 23, 2021
@amyangfei amyangfei added this to the v5.2.3 milestone Nov 23, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 00d104c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2021
@amyangfei
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test
/run-unit-test

@amyangfei
Copy link
Contributor

/run-integration-test
/run-unit-test

@amyangfei
Copy link
Contributor

/run-kafka-integration-test
/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 96a119c into pingcap:release-5.2 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @amyangfei @zhouqiang-cl