Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec: canal-json support batch decoder #3203

Merged
merged 40 commits into from
Nov 17, 2021
Merged

codec: canal-json support batch decoder #3203

merged 40 commits into from
Nov 17, 2021

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Oct 31, 2021 •
edited
Loading

What problem does this PR solve?

This is a partwork of making Kafka Sink GA, support batch decoder interface for Canal-JSON format.

What is changed and how it works?

  • implement the EventBatchDecoder for Canal-JSON protocol.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2021
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch from 27b68bf to 7a59fd0 Compare October 31, 2021 13:04
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2021
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch from 7a59fd0 to a492461 Compare November 8, 2021 09:03
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2021
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch from a492461 to 83c1b27 Compare November 11, 2021 07:57
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2021
@3AceShowHand 3AceShowHand added component/sink Sink component. status/ptal Could you please take a look? labels Nov 12, 2021
@3AceShowHand 3AceShowHand changed the title [DNM]codec: refactor canal-json encoding [DNM]codec: canal-json support batch decoder Nov 12, 2021
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch from 41d60ed to 8307c7d Compare November 12, 2021 09:16
@3AceShowHand 3AceShowHand changed the title [DNM]codec: canal-json support batch decoder codec: canal-json support batch decoder Nov 12, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2021
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch 2 times, most recently from 3236e8d to a5027d0 Compare November 13, 2021 06:56
@3AceShowHand 3AceShowHand force-pushed the refact-canal-flat-json-encoder branch from 48ea341 to f7011dd Compare November 17, 2021 09:08
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
overvenus
overvenus approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c6fa681

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2021
@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/run-integration-tests

@3AceShowHand
Copy link
Contributor Author

/run-dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3203 (bc28a87) into master (24030f8) will increase coverage by 1.3041%.
The diff coverage is 69.0663%.

@@               Coverage Diff                @@
##             master      #3203        +/-   ##
================================================
+ Coverage   56.5356%   57.8397%   +1.3041%     
================================================
  Files           211        233        +22     
  Lines         22798      23942      +1144     
================================================
+ Hits          12889      13848       +959     
- Misses         8598       8694        +96     
- Partials       1311       1400        +89

@ti-chi-bot ti-chi-bot merged commit c865fd1 into pingcap:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@asddongmen asddongmen Awaiting requested review from asddongmen

@ben1009 ben1009 Awaiting requested review from ben1009

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

@maxshuang maxshuang Awaiting requested review from maxshuang

@lonng lonng Awaiting requested review from lonng

@liuzix liuzix Awaiting requested review from liuzix

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
component/sink Sink component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@3AceShowHand @ti-chi-bot @overvenus @codecov-commenter @amyangfei @lonng @liuzix