Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Release new owner / processor implementation to release-4.0 #2947

Closed
wants to merge 2 commits into from
Closed

*: Release new owner / processor implementation to release-4.0 #2947

wants to merge 2 commits into from

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

#2765

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2021
@asddongmen asddongmen changed the base branch from master to release-4.0 September 27, 2021 07:13
@ti-chi-bot
Copy link
Member

@asddongmen: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2021
@asddongmen asddongmen added the component/replica-model Replication model component. label Sep 27, 2021
@3AceShowHand
Copy link
Contributor

please change the title to follow the PR format convention.

@asddongmen asddongmen changed the title Turn on new replicate model on release-4.0 *: Release new owner / processor implementation to release-4.0 Sep 27, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021
overvenus
overvenus reviewed Sep 28, 2021
View reviewed changes
pkg/config/config.go
@@ -32,7 +32,7 @@ import (
const (
// NewReplicaImpl is true if we using new processor
// new owner should be also switched on after it implemented
NewReplicaImpl = false
NewReplicaImpl = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the flag and delete old owner code?

ben1009
ben1009 reviewed Sep 28, 2021
View reviewed changes
tests/changefeed_error/run.sh
@@ -7,17 +7,17 @@ source $CUR/../_utils/test_prepare
WORK_DIR=$OUT_DIR/$TEST_NAME
CDC_BINARY=cdc.test
SINK_TYPE=$1
MAX_RETRIES=10
MAX_RETRIES=20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to 20?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2021
@ti-chi-bot
Copy link
Member

@asddongmen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen asddongmen closed this Oct 8, 2021
@asddongmen asddongmen deleted the asddongmen_turn_on_new_replicate_model_on_branch4.0 branch November 16, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 left review comments

@overvenus overvenus overvenus left review comments

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
component/replica-model Replication model component. do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asddongmen @ti-chi-bot @3AceShowHand @ben1009 @overvenus