*: Release new owner / processor implementation to release-5.0 #2946

asddongmen · 2021-09-27T07:00:51Z

What problem does this PR solve?

Close https://github.com/pingcap/ticdc/pull/2668
Close https://github.com/pingcap/ticdc/pull/2610
Close https://github.com/pingcap/ticdc/pull/2633

Cherry-pick: https://github.com/pingcap/ticdc/pull/2752

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update key monitor metrics in both TiCDC document and official document

Release note

Release new owner and processor implementation to release-5.0.
Highly available model and core modules refactoring.(ref: https://github.com/pingcap/ticdc/pull/1927)

ti-chi-bot · 2021-09-27T07:00:52Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

amyangfei
overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

asddongmen · 2021-09-27T07:05:50Z

/run-all-tests

asddongmen · 2021-09-27T09:29:16Z

/run-all-tests

asddongmen · 2021-09-27T10:36:13Z

/run-integration-tests

asddongmen · 2021-09-27T12:43:02Z

/run-integration-tests

ben1009 · 2021-09-28T03:21:17Z

pkg/config/config.go

@@ -32,7 +32,7 @@ import (
 const (
 	// NewReplicaImpl is true if we using new processor
 	// new owner should be also switched on after it implemented
-	NewReplicaImpl = false
+	NewReplicaImpl = true


we keep the flag mean it is possible will switch back to old one ? if not could delete the flag, make it as the default behaviour ?

i wil clean all related codes in another pr after this pr merge.

asddongmen · 2021-10-09T12:02:58Z

/run-all-tests

amyangfei · 2021-10-11T03:15:31Z

Please add release note

amyangfei · 2021-10-11T09:35:10Z

/merge

ti-chi-bot · 2021-10-11T09:35:13Z

This pull request has been accepted and is ready to merge.

Commit hash: 0142497

ti-chi-bot · 2021-10-11T09:35:23Z

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

overvenus · 2021-10-11T13:17:36Z

/run-integration-tests

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2021-10-11T13:38:02Z

In response to a cherrypick label: new pull request created: #3014.

#3014) * This is an automated cherry-pick of #2946 Signed-off-by: ti-chi-bot <[email protected]> * fix ci error * fix_integration_error * tests: fix it error * tests:fix it error * tests/move_table: skip kafka sink integration test Co-authored-by: dongmen <[email protected]> Co-authored-by: dongmen <[email protected]>

asddongmen added 2 commits September 27, 2021 14:56

*: turn on new replicate model

adb848a

Merge remote-tracking branch 'upstream/release-5.0' into release-5.0

1d60d9b

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Sep 27, 2021

ti-chi-bot requested review from amyangfei and Rustin170506 September 27, 2021 07:01

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 27, 2021

asddongmen added the component/replica-model Replication model component. label Sep 27, 2021

asddongmen changed the title ~~Turn on new replicate model on release-5.0~~ *: Release new owner / processor implementation to release-4.0 Sep 27, 2021

asddongmen changed the title *: Release new owner / processor implementation to release-4.0 *: Release new owner / processor implementation to release-5.0 Sep 27, 2021

tests: update integration tests

55f4104

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2021

tests: update integration tests

5a0f13e

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2021

tests: update integration tests

93a7bbd

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2021

ben1009 reviewed Sep 28, 2021

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

Merge branch 'release-5.0' into turn_on_new_replicate_model_on_branch5.0

9834799

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2021

asddongmen added status/ptal Could you please take a look? and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 9, 2021

amyangfei added this to the v5.0.5 milestone Oct 11, 2021

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 11, 2021

overvenus approved these changes Oct 11, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021

nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 11, 2021

amyangfei approved these changes Oct 11, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2021

Merge branch 'release-5.0' into turn_on_new_replicate_model_on_branch5.0

1c7cc48

ti-chi-bot merged commit fdf4b52 into pingcap:release-5.0 Oct 11, 2021

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 11, 2021

This is an automated cherry-pick of pingcap#2946

1b65128

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Oct 11, 2021

*: Release new owner / processor implementation to release-4.0 (#2946) #3014

Merged

overvenus mentioned this pull request Oct 11, 2021

replication: switch on new owner 5.0 #2143

Closed

asddongmen deleted the turn_on_new_replicate_model_on_branch5.0 branch November 16, 2021 10:55

amyangfei mentioned this pull request Dec 9, 2021

The abnormal changefeed impact other normal changefeed to sync task #1708

Closed

zhouqiang-cl modified the milestones: v5.0.5, v5.0.6 Dec 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Release new owner / processor implementation to release-5.0 #2946

*: Release new owner / processor implementation to release-5.0 #2946

asddongmen commented Sep 27, 2021 •

edited by overvenus

Loading

ti-chi-bot commented Sep 27, 2021 •

edited

Loading

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

ben1009 Sep 28, 2021

asddongmen Sep 28, 2021

asddongmen commented Oct 9, 2021

amyangfei commented Oct 11, 2021

amyangfei commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

overvenus commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

*: Release new owner / processor implementation to release-5.0 #2946

*: Release new owner / processor implementation to release-5.0 #2946

Conversation

asddongmen commented Sep 27, 2021 • edited by overvenus Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Sep 27, 2021 • edited Loading

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

asddongmen commented Sep 27, 2021

ben1009 Sep 28, 2021

Choose a reason for hiding this comment

asddongmen Sep 28, 2021

Choose a reason for hiding this comment

asddongmen commented Oct 9, 2021

amyangfei commented Oct 11, 2021

amyangfei commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

overvenus commented Oct 11, 2021

ti-chi-bot commented Oct 11, 2021

asddongmen commented Sep 27, 2021 •

edited by overvenus

Loading

ti-chi-bot commented Sep 27, 2021 •

edited

Loading