sink: fix codec json encoding with non binary string (#2764) #2781
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2764
What problem does this PR solve?
Close #2758
Note we still don't known in which scenario the column value is
string
instead of[]byte
, need more investigation.What is changed and how it works?
The column value type of
mysql.TypeString
,mysql.TypeVarString
,mysql.TypeVarchar
could be eitherstring
or[]byte
, we should consider both of these two types when converting a row column value to json encoding.Check List
Tests
Release note