Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TestRemoveNode timeout #2618

Merged
merged 3 commits into from
Aug 25, 2021
Merged

test: fix TestRemoveNode timeout #2618

merged 3 commits into from
Aug 25, 2021

Conversation

ben1009
Copy link
Contributor

@ben1009 ben1009 commented Aug 24, 2021

What problem does this PR solve?

https://github.com/pingcap/ticdc/issues/2614

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 24, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. component/test Unit tests and integration tests component. labels Aug 24, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@ben1009 ben1009 linked an issue Aug 24, 2021 that may be closed by this pull request
unstable unit test frontier.(*tsHeapSuite).TestRemoveNode timeout #2614
Closed
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2659e58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@amyangfei
Copy link
Contributor

/run-unit-tests
/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2618 (1b79704) into master (f3fdd65) will increase coverage by 5.1760%.
The diff coverage is 69.0283%.

@@               Coverage Diff                @@
##             master      #2618        +/-   ##
================================================
+ Coverage   56.0786%   61.2546%   +5.1760%     
================================================
  Files           169        161         -8     
  Lines         20605      17917      -2688     
================================================
- Hits          11555      10975       -580     
+ Misses         7919       5948      -1971     
+ Partials       1131        994       -137

@ti-chi-bot ti-chi-bot merged commit 2cde641 into master Aug 25, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2628.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2629.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2630.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2631.

ti-chi-bot added a commit that referenced this pull request Aug 29, 2021
@ti-chi-bot
test: fix TestRemoveNode timeout (#2618) (#2628)
df64690
ti-chi-bot added a commit that referenced this pull request Aug 29, 2021
@ti-chi-bot
test: fix TestRemoveNode timeout (#2618) (#2630)
6c35615
ti-chi-bot added a commit that referenced this pull request Aug 29, 2021
@ti-chi-bot
test: fix TestRemoveNode timeout (#2618) (#2629)
0999a92
@ben1009 ben1009 deleted the cdc-TestRemoveNode branch August 30, 2021 03:02
ti-chi-bot added a commit that referenced this pull request Aug 30, 2021
@ti-chi-bot
test: fix TestRemoveNode timeout (#2618) (#2631)
b35edc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable unit test frontier.(*tsHeapSuite).TestRemoveNode timeout
5 participants
@ben1009 @ti-chi-bot @amyangfei @codecov-commenter @Rustin170506