Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: prohibit operating TiCDC clusters across major and minor versions (#2481) #2600

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2481

What problem does this PR solve?

Prohibit operating TiCDC clusters across major versions

What is changed and how it works?

Add version check for both TiDB cluster and TiCDC cluster.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
tiup playground v5.1.0 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // ok

tiup playground v5.0.3 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // error "CDC:ErrVersionIncompatible"

tiup playground v4.0.14 --tiflash 0 --ticdc 1
cdc cli --pd http://127.0.0.1:2379 capture list // error "CDC:ErrVersionIncompatible"

// Or there is no TiCDC cluster
cdc cli --pd http://127.0.0.1:2379 capture list // error TiCDC cluster is unknown, please start TiCDC cluster

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

Prohibit operating TiCDC clusters across major and minor versions

overvenus and others added 26 commits August 20, 2021 13:39
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/cli CLI component. labels Aug 20, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and liuzix August 20, 2021 13:39
@overvenus
Copy link
Member

/run-kafka-tests
/run-integration-tests

@overvenus
Copy link
Member

/run-kafka-tests
/run-integration-tests

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7ce67ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2021
@amyangfei amyangfei added this to the v5.2.0 milestone Aug 21, 2021
@amyangfei
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2021
Comment on lines 50 to 52
docker run pingcap/tidb:nightly -V
docker run pingcap/tikv:nightly -V
docker run pingcap/pd:nightly -V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image tagv5.2.0-nightly is not available in docker hub currently, which will be uploaded after 5.2.0 is released. Since the integration test is not enabled in release branch, it is safe to change all tags to v5.2.0-nightly now.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0faa15d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2021
@amyangfei
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2600 (e0e43fa) into release-5.2 (f3fdd65) will decrease coverage by 0.2106%.
The diff coverage is 64.0449%.

@@                 Coverage Diff                 @@
##           release-5.2      #2600        +/-   ##
===================================================
- Coverage      56.0786%   55.8679%   -0.2107%     
===================================================
  Files              169        169                
  Lines            20605      20663        +58     
===================================================
- Hits             11555      11544        -11     
- Misses            7919       8012        +93     
+ Partials          1131       1107        -24     

@ti-chi-bot ti-chi-bot merged commit 9e410de into pingcap:release-5.2 Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cli CLI component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants