Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add integration test for http api #2563

Merged
merged 17 commits into from
Aug 20, 2021
Merged

tests: Add integration test for http api #2563

merged 17 commits into from
Aug 20, 2021

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Aug 18, 2021 •
edited
Loading

What problem does this PR solve?

#2412

What is changed and how it works?

Add integration tests for all Open API.

Check List

Tests

  • No code

Release note 

None

@asddongmen asddongmen added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@asddongmen asddongmen self-assigned this Aug 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 18, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and liuzix August 18, 2021 06:59
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2021
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen asddongmen marked this pull request as draft August 18, 2021 09:59
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2021
@asddongmen
Copy link
Contributor Author

/run-kafka-tests

@asddongmen
Copy link
Contributor Author

/run-unit-tests

@asddongmen asddongmen removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 18, 2021
@asddongmen asddongmen marked this pull request as ready for review August 18, 2021 10:34
@asddongmen asddongmen added the status/ptal Could you please take a look? label Aug 18, 2021
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen asddongmen restored the add_http_api_test1 branch August 20, 2021 01:27
@asddongmen asddongmen reopened this Aug 20, 2021
@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen
Copy link
Contributor Author

/run-kafka-tests

Rustin170506
Rustin170506 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM 👍

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021
amyangfei
amyangfei reviewed Aug 20, 2021
View reviewed changes
@asddongmen
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 36a4eab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit fcd6cca into pingcap:master Aug 20, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2597.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2021
Merged
ti-chi-bot added a commit that referenced this pull request Aug 21, 2021
@ti-chi-bot
tests: Add integration test for http api (#2563) (#2597)
4c1896a
@asddongmen asddongmen deleted the add_http_api_test1 branch October 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@asddongmen asddongmen

Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asddongmen @ti-chi-bot @codecov-commenter @amyangfei @Rustin170506