-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli(refactor): add create changefeed cmd #2539
cli(refactor): add create changefeed cmd #2539
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/uncc liuzx lonng |
/cc @amyangfei @overvenus @3AceShowHand Could you please take a look? Also, I don't know if I should decouple the getInfo method, because it actually does two things: 1. gets and completes the cfg 2. generates info. But since we use cfg in info, we put it together. Do you think it needs to be decoupled? Also in the process of completing the cfg we are constantly outputting warning messages to cmd. I'm not sure if decoupling will have any effect on these warnings. For example, the order and timing of its appearance. Can you guys help with some advice? |
What are these warning messages? |
We output a lot of warnings in the process of completing the cfg. |
rest LGTM |
@amyangfei @overvenus @asddongmen This PR tested in pingcap/ticdc@f13b168. All tests passed. The code changes are quite significant and may require very careful review. Thanks! ❤️ |
/run-all-tests |
/run-all-tests |
@amyangfei @overvenus ping~ Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 88f51c1
|
Codecov Report
@@ Coverage Diff @@
## master #2539 +/- ##
================================================
+ Coverage 56.0786% 61.1722% +5.0935%
================================================
Files 169 161 -8
Lines 20605 17915 -2690
================================================
- Hits 11555 10959 -596
+ Misses 7919 5958 -1961
+ Partials 1131 998 -133 |
In response to a cherrypick label: new pull request created: #2611. |
What problem does this PR solve?
split from https://github.com/pingcap/ticdc/pull/2482
What is changed and how it works?
add create changefeed cmd.
Check List
Tests
None
Code changes
Side effects
None
Related changes
None
Release note