*: enable lint test. #11647
*: enable lint test. #11647
Conversation
ti-chi-bot
bot
added
release-note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11647 +/- ##
================================================
+ Coverage 55.2635% 55.3246% +0.0610%
================================================
Files 1001 1001
Lines 136162 136310 +148
================================================
+ Hits 75248 75413 +165
+ Misses 55426 55409 -17
Partials 5488 5488 |
There was a problem hiding this comment.
we can see only dm uses "github.com/pingcap/check". we should replace it with testify gradually. pingcap/tidb#26022
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
the cdc part LGTM |
| @@ -615,6 +615,7 @@ func processEvent( | |||
| return nil, event, nil | |||
| } | |||
| } | |||
| // nolint | |||
There was a problem hiding this comment.
Could you please explain why the // nolint comment was added here?
There was a problem hiding this comment.
This nolint is used for revive check，if last else with return or break，suggest to remove else part.
| @@ -99,6 +99,7 @@ func codecEncodeKeyPB(event *model.RowChangedEvent) []byte { | |||
| RowId: event.RowID, | |||
| Partition: 0, | |||
| } | |||
| // nolint | |||
There was a problem hiding this comment.
Is there an issue with the current linting for panic, which is why the // nolint comment was added here?
There was a problem hiding this comment.
This is also revive check, suggest to remove else part of if statement.
|
@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@purelind: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, lance6716, purelind, wlwilliamx, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test cdc-integration-storage-test |
What problem does this PR solve?
Issue Number: ref #11606
What is changed and how it works?
enable lint checks that was temp disable due to upgrade go to 1.23.
Check List
Tests
[x] No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note