Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer(ticdc): partition resolved ts fallback ignore caused by read offset message #11412

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jul 22, 2024

What problem does this PR solve?

Issue Number: close #11413

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5326%. Comparing base (2fcbb31) to head (75ca6e8).

Additional details and impacted files
Components Coverage Δ
cdc 61.2425% <ø> (+0.0303%) ⬆️
dm 51.1828% <ø> (-0.0283%) ⬇️
engine 63.3950% <ø> (ø)
Flag Coverage Δ
unit 57.5326% <ø> (+0.0039%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11412        +/-   ##
================================================
+ Coverage   57.5287%   57.5326%   +0.0039%     
================================================
  Files           849        849                
  Lines        126356     126356                
================================================
+ Hits          72691      72696         +5     
+ Misses        48255      48250         -5     
  Partials       5410       5410                

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 22, 2024
@3AceShowHand
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 30, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-30 06:57:28.049446367 +0000 UTC m=+252564.329494447: ☑️ agreed by hongyunyan.
  • 2024-07-30 06:58:05.234003852 +0000 UTC m=+252601.514051918: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot merged commit 65e6dca into pingcap:master Jul 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka consumer ignore partition resolved ts fallback if caused by read old offset message
3 participants