Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec(ticdc): avro simplify the unit test #11010

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Apr 29, 2024

What problem does this PR solve?

Issue Number: close #11014

What is changed and how it works?

  • remove some useless avro unit test
  • use schema test helper to generate the events

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5036%. Comparing base (ba6db07) to head (4c2becb).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.8021% <ø> (+0.0965%) ⬆️
dm 51.3440% <ø> (+0.0912%) ⬆️
engine 63.4585% <ø> (+0.0706%) ⬆️
Flag Coverage Δ
unit 57.5036% <ø> (+0.0893%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11010        +/-   ##
================================================
+ Coverage   57.4142%   57.5036%   +0.0893%     
================================================
  Files           851        851                
  Lines        125225     125253        +28     
================================================
+ Hits          71897      72025       +128     
+ Misses        47936      47845        -91     
+ Partials       5392       5383         -9     

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 29, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 04:31:13.525048653 +0000 UTC m=+331627.282184230: ☑️ agreed by asddongmen.
  • 2024-04-30 07:05:09.085309025 +0000 UTC m=+340862.842444595: ☑️ agreed by sdojjy.

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit be15534 into pingcap:master Apr 30, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avro unit test simplification and use schema test helper
3 participants