Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: specify tidb commit #10589

Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Feb 6, 2024

What problem does this PR solve?

Issue Number: close #10588

What is changed and how it works?

all checksum integration tests is failed because of upstream tidb changes, in this PR we use a specified tidb commit to run integration tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

```release-noteNone`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 6, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Feb 6, 2024

/retest-required

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 06:24:41.191210337 +0000 UTC m=+251606.757980229: ☑️ agreed by CharlesCheung96.
  • 2024-02-06 06:35:46.448719675 +0000 UTC m=+252272.015489567: ☑️ agreed by asddongmen.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #10589 (61d059f) into master (13eb7a3) will decrease coverage by 0.0088%.
The diff coverage is n/a.

Additional details and impacted files
Components Coverage Δ
cdc 61.9700% <ø> (-0.0230%) ⬇️
dm 51.2537% <ø> (+0.0060%) ⬆️
engine 63.3929% <ø> (ø)
Flag Coverage Δ
unit 57.5755% <ø> (-0.0088%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10589        +/-   ##
================================================
- Coverage   57.5843%   57.5755%   -0.0088%     
================================================
  Files           849        849                
  Lines        125984     125984                
================================================
- Hits          72547      72536        -11     
- Misses        48007      48014         +7     
- Partials       5430       5434         +4     

@ti-chi-bot ti-chi-bot bot merged commit 79d5246 into pingcap:master Feb 6, 2024
28 checks passed
@sdojjy sdojjy deleted the specify-tidb-commit-to-correct-tests branch February 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: specify tidb commit
3 participants