Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable tls test for DM #10414

Merged
merged 7 commits into from
Jan 5, 2024
Merged

test: enable tls test for DM #10414

merged 7 commits into from
Jan 5, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jan 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10413

What is changed and how it works?

after etcd upgrading, the default value of EnableGRPCGateway becomes true, so we need to manually turn it off. see pingcap/dm#1458

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2024
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 4, 2024
@lance6716
Copy link
Contributor Author

/hold

the log shows there's still connections keeps retrying and fails the TLS handshake. Will locate where it comes

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
@lance6716
print more log
375ec40 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2024
@lance6716
change debug log
8d5ddc7 
Signed-off-by: lance6716 <[email protected]>
@lance6716
reorder
3a531aa 
Signed-off-by: lance6716 <[email protected]>
@lance6716
make fmt
abf950e 
Signed-off-by: lance6716 <[email protected]>
@lance6716
update test
4a777a8 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
Benjamin2037
Benjamin2037 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD
GMHDBJD approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 02:25:07.91263018 +0000 UTC m=+2310198.949857106: ☑️ agreed by D3Hunter.
  • 2024-01-05 06:17:00.432343203 +0000 UTC m=+2410511.469570114: ☑️ agreed by GMHDBJD.

@lance6716
Copy link
Contributor Author

/retest

1 similar comment
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 368d20f into pingcap:master Jan 5, 2024
14 checks passed
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Apr 25, 2024
@lance6716 @3AceShowHand
test: enable tls test for DM (pingcap#10414)
7d063b3 
close pingcap#10413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM tls test is failed
4 participants
@lance6716 @D3Hunter @Benjamin2037 @GMHDBJD