Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller(cdc): add metrics for slowest changefeed puller #10054

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 9, 2023

What problem does this PR solve?

Issue Number: close #10053

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-linked-issue labels Nov 9, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Nov 9, 2023

图片

Here are new graphs for changed panels.

@hicqu hicqu requested review from sdojjy and 3AceShowHand November 9, 2023 09:06
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 9, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 09:10:21.058480879 +0000 UTC m=+3721818.645591024: ☑️ agreed by 3AceShowHand.
  • 2023-11-09 12:06:35.770285365 +0000 UTC m=+3732393.357395510: ☑️ agreed by sdojjy.

@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit bf206ea into pingcap:master Nov 9, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10066.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10068.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 9, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10069.

@hicqu hicqu deleted the kv-client-metrics branch November 9, 2023 15:50
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Nov 9, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a metric panel about TiCDC puller ResolvedTs lag
5 participants