Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner(cdc): add owner for cdc v2 #10034

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 8, 2023

What problem does this PR solve?

Issue Number: close #10033

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2023
cdcv2/owner/owner.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 8, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Nov 8, 2023

/test verify

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2023

@3AceShowHand: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdojjy
Copy link
Member Author

sdojjy commented Nov 8, 2023

/test verify

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 9, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 9, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 06:35:55.379690672 +0000 UTC m=+3626152.966800824: ☑️ agreed by 3AceShowHand.
  • 2023-11-09 11:45:09.093631464 +0000 UTC m=+3731106.680741610: ☑️ agreed by CharlesCheung96.

@sdojjy
Copy link
Member Author

sdojjy commented Nov 10, 2023

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot bot merged commit b2011a6 into pingcap:master Nov 10, 2023
@sdojjy sdojjy deleted the add-ower-for-cdc-v2 branch November 10, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owner(cdc): add owner for cdc v2
3 participants