Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: OptShardingGroupKeeper should be reset when resume task #9588

Closed
GMHDBJD opened this issue Aug 16, 2023 · 0 comments · Fixed by #9707
Closed

dm: OptShardingGroupKeeper should be reset when resume task #9588

GMHDBJD opened this issue Aug 16, 2023 · 0 comments · Fixed by #9707
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Aug 16, 2023

What did you do?

skip a conflict ddl, resume task

What did you expect to see?

task replicate as normal

What did you see instead?

OptShardingGroupKeeper not reset, all dml are skipped

Versions of the cluster

DM version (run dmctl -V or dm-worker -V or dm-master -V):

(paste DM version here, and you must ensure versions of dmctl, DM-worker and DM-master are same)

Upstream MySQL/MariaDB server version:

(paste upstream MySQL/MariaDB server version here)

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

How did you deploy DM: tiup or manually?

(leave TiUP or manually here)

Other interesting information (system version, hardware config, etc):

>
>

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@GMHDBJD GMHDBJD added type/bug The issue is confirmed as a bug. severity/moderate area/dm Issues or PRs related to DM. affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 labels Aug 16, 2023
@GMHDBJD GMHDBJD mentioned this issue Sep 8, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2023
@GMHDBJD
dm: reset optimistic sharding group keeper when syncer resume (#9707)
78d59fc 
close #9588
This was referenced Sep 11, 2023
Closed
Open
Open
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 20, 2023
@ti-chi-bot
dm: reset optimistic sharding group keeper when syncer resume (#9707) (…
b9bee64 
…#9719)

close #9588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dm: reset optimistic sharding group keeper when syncer resume GMHDBJD/tiflow
1 participant
@GMHDBJD