Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add strict optimistic shard mode #9112

Closed
GMHDBJD opened this issue Jun 1, 2023 · 0 comments · Fixed by #9113
Closed

dm: add strict optimistic shard mode #9112

GMHDBJD opened this issue Jun 1, 2023 · 0 comments · Fixed by #9113
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. area/dm Issues or PRs related to DM. type/feature Issues about a new feature

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 1, 2023 •
edited
Loading

Is your feature request related to a problem?

For some DDL like alter table rename column, we skip all dml and ddl for that shard table until all shard tables meet the same rename column statement in optimistic mode. However, some user use optimistic mode in test environment and want to know the incompatible DDL immediately.

Describe the feature you'd like

add a config item strict-optimistic-shard-mode, when we meet DDL like alter table rename column, return the error immediately.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@GMHDBJD GMHDBJD added type/feature Issues about a new feature area/dm Issues or PRs related to DM. labels Jun 1, 2023
@GMHDBJD GMHDBJD mentioned this issue Jun 1, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 13, 2023
@GMHDBJD
dm: add strict optimist mode (#9113)
b7ce4c2 
close #9112
@ti-chi-bot ti-chi-bot mentioned this issue Jun 13, 2023
Merged
@GMHDBJD GMHDBJD mentioned this issue Jun 19, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 20, 2023
@GMHDBJD
shardddl: return error if conflict happened when receive conflict det…
10b9850 
…ect operation (#9263)

ref #9112
@ti-chi-bot ti-chi-bot mentioned this issue Jun 20, 2023
Merged
GMHDBJD added a commit to ti-chi-bot/tiflow that referenced this issue Jun 26, 2023
@GMHDBJD
shardddl: return error if conflict happened when receive conflict det…
ef9a735 
…ect operation (pingcap#9263)

ref pingcap#9112
@ti-chi-bot ti-chi-bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot mentioned this issue Aug 10, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 16, 2023
@ti-chi-bot
dm: add strict optimist mode (#9113) (#9212)
28b0657 
close #9112
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@ti-chi-bot
dm: add strict optimist mode (#9113) (#9540)
ff869a6 
close #9112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. area/dm Issues or PRs related to DM. type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dm: add strict optimist mode GMHDBJD/tiflow
2 participants
@GMHDBJD @ti-chi-bot