Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc output ddl count metrics is inaccurate #11511

Closed
3AceShowHand opened this issue Aug 23, 2024 · 0 comments · Fixed by #11510
Closed

ticdc output ddl count metrics is inaccurate #11511

3AceShowHand opened this issue Aug 23, 2024 · 0 comments · Fixed by #11510
Assignees
@3AceShowHand
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@3AceShowHand
Copy link
Contributor

What did you do?

  • execute some ddl on the upstream TiDB cluster.
  • observe TiCDC logs and metrics. logs show that 30 DDLs executed within 1 minutes, but the metrics shows only around 7 DDLs.

What did you expect to see?

The metrics show the count of executed DDLs correctly

What did you see instead?

The metrics show the count of executed DDLs incorrectly

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

master
@3AceShowHand 3AceShowHand added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Aug 23, 2024
@3AceShowHand 3AceShowHand self-assigned this Aug 23, 2024
@3AceShowHand 3AceShowHand added severity/minor component/metrics-logging Metrics and logging component. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Aug 23, 2024
@3AceShowHand 3AceShowHand mentioned this issue Aug 23, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 23, 2024
@3AceShowHand
metrics(ticdc): fix ddl executed count metrics (#11510)
73fe3e4 
close #11511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. severity/minor type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics(ticdc): fix ddl executed count metrics 3AceShowHand/tiflow
1 participant
@3AceShowHand