Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(mysql) execute DMLs first and then set session variables #10322

Closed
zhangjinpeng87 opened this issue Dec 18, 2023 · 0 comments · Fixed by #10323
Closed

sink(mysql) execute DMLs first and then set session variables #10322

zhangjinpeng87 opened this issue Dec 18, 2023 · 0 comments · Fixed by #10323
Assignees
@zhangjinpeng87
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@zhangjinpeng87
Copy link
Contributor

In https://github.com/pingcap/tiflow/blob/master/cdc/sink/dmlsink/txn/mysql/mysql.go execDMLWithMaxRetries execute DMLs and then set session variables. This is probably ok for TiDB, but make it more generic we should set session variables and other transaction context first and then run DMLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangjinpeng87 zhangjinpeng87

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sink-mysql(cdc) set variables first and then execute DMLs zhangjinpeng87/tiflow
1 participant
@zhangjinpeng87