Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CDC) sourcemanager/engine folder name can't represent its semantic clearly #10272

Closed
zhangjinpeng87 opened this issue Dec 9, 2023 · 0 comments · Fixed by #10273
Closed

(CDC) sourcemanager/engine folder name can't represent its semantic clearly #10272

zhangjinpeng87 opened this issue Dec 9, 2023 · 0 comments · Fixed by #10273
Assignees
@zhangjinpeng87
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@zhangjinpeng87
Copy link
Contributor

https://github.com/pingcap/tiflow/tree/master/cdc/processor/sourcemanager/engine the name of engine here is easy to confuse with https://github.com/pingcap/tiflow/tree/master/engine, and the name engine can not represent its semantic clearly.
@zhangjinpeng87 zhangjinpeng87 self-assigned this Dec 9, 2023
@zhangjinpeng87 zhangjinpeng87 mentioned this issue Dec 9, 2023
Merged
@zhangjinpeng87 zhangjinpeng87 added the type/enhancement The issue or PR belongs to an enhancement. label Dec 9, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 12, 2023
@zhangjinpeng87
sorter(ticdc) make the name more clear (#10273)
f582632 
close #10272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangjinpeng87 zhangjinpeng87

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sorter(ticdc) make the name more clear zhangjinpeng87/tiflow
1 participant
@zhangjinpeng87