Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to custom and disable redo event cache #10143

Closed
hicqu opened this issue Nov 23, 2023 · 0 comments · Fixed by #10139
Closed

Allow to custom and disable redo event cache #10143

hicqu opened this issue Nov 23, 2023 · 0 comments · Fixed by #10139
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@hicqu
Copy link
Contributor

hicqu commented Nov 23, 2023 •
edited
Loading

Description

Currently if consistent is enabled, changefeed memory quota will be seperated into

  • 1/4 for sink;
  • 3/8 for redo;
  • 3/8 for redo event cache.

However, redo event cache can't make help as expected. It's because cache hit ratio can only be high enough under light workloads.
@hicqu hicqu added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Nov 23, 2023
@hicqu hicqu added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Nov 23, 2023
@hicqu hicqu mentioned this issue Nov 23, 2023
Merged
@sdojjy sdojjy added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 15, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 16, 2023
@hicqu
redo(cdc): custom redo event cache and disable it by default (#10139)
844b41b 
close #10143
@ti-chi-bot ti-chi-bot mentioned this issue Dec 16, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 16, 2023
@hicqu @ti-chi-bot
redo(cdc): custom redo event cache and disable it by default (pingcap…
ff65ea6 
…#10139)

close pingcap#10143
@ti-chi-bot ti-chi-bot mentioned this issue Dec 16, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Dec 16, 2023
@hicqu @ti-chi-bot
redo(cdc): custom redo event cache and disable it by default (pingcap…
71d0374 
…#10139)

close pingcap#10143
@ti-chi-bot ti-chi-bot mentioned this issue Dec 16, 2023
Merged
@hicqu hicqu mentioned this issue Dec 17, 2023
Open
sdojjy pushed a commit to sdojjy/tiflow that referenced this issue Dec 18, 2023
@hicqu @sdojjy
redo(cdc): custom redo event cache and disable it by default (pingcap…
4cd1ed1 
…#10139)

close pingcap#10143
# Conflicts:
#	cdc/processor/sinkmanager/manager.go
@sdojjy sdojjy mentioned this issue Dec 18, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 18, 2023
@ti-chi-bot
redo(cdc): custom redo event cache and disable it by default (#10139) (…
725d938 
…#10316)

close #10143
ti-chi-bot bot pushed a commit that referenced this issue Dec 19, 2023
@ti-chi-bot
redo(cdc): custom redo event cache and disable it by default (#10139) (…
6c17848 
…#10315)

close #10143
This was referenced Jan 15, 2024
Merged
Closed
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Jan 31, 2024
@hicqu
redo(cdc): custom redo event cache and disable it by default (pingcap…
4ed749b 
…#10139)

close pingcap#10143
ti-chi-bot bot pushed a commit that referenced this issue Feb 1, 2024
@ti-chi-bot
redo(cdc): custom redo event cache and disable it by default (#10139) (…
b5fa563 
…#10317)

close #10143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redo(cdc): custom redo event cache and disable it by default hicqu/ticdc
2 participants
@sdojjy @hicqu