*: Remove RegionPtrWithBlock #9735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/work-in-progress
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
force-pushed
the
remove_region_with_block
branch
from
6783f5e to
2b3699a
Compare
ti-chi-bot
bot
added
size/XL
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
JaySon-Huang
commented
Dec 19, 2024
JaySon-Huang
changed the title
Lloyd-Pottiger
approved these changes
Dec 19, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
approved these changes
Dec 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
Previous to v5.0, when handling apply snapshot, tiflash always decode the committed rows into block then write the blocks into IStorage layer. This is implemented with
RegionPtrWithBlock.Later we introduce
SSTFilesToDTFilesOutputStreamto reduce the impact of applying snapshot (#1439).RegionPtrWithBlockbecome only used for some testing. It make some codes in the raft layer more complicated to be understand now.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note