build: fix drawin build #9545
Merged
build: fix drawin build #9545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lloyd-Pottiger <[email protected]>
ti-chi-bot
bot
added
release-note-none
JinheLin
reviewed
Oct 21, 2024
| @@ -41,6 +41,11 @@ class ColumnFileTiny : public ColumnFilePersisted | |||
|
|
|||
| struct IndexInfo | |||
| { | |||
| IndexInfo(PageIdU64 page_id, std::optional<dtpb::VectorIndexFileProps> vec_index) | |||
| : index_page_id(page_id) | |||
| , vector_index(vec_index) | |||
There was a problem hiding this comment.
Suggested change
| , vector_index(vec_index) | |
| , vector_index(std::move(vec_index)) |
There was a problem hiding this comment.
Can not move here.
There was a problem hiding this comment.
Why we need to add a ctor function of IndexInfo? What's the error on darwin build
There was a problem hiding this comment.
[ 98%] Building CXX object dbms/src/Storages/DeltaMerge/CMakeFiles/delta_merge.dir/ColumnFile/ColumnFileTiny.cpp.o
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:15:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Exception.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Logger.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/FmtUtils.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/compile.h:11:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/format.h:41:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/memory:673:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocation_guard.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocator_traits.h:298:9: error: no matching function for call to 'construct_at'
_VSTD::construct_at(__p, _VSTD::forward<_Args>(__args)...);
^~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:858:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_ABI_NAMESPACE
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:948:21: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<DB::DM::ColumnFileTiny::IndexInfo>>::construct<DB::DM::ColumnFileTiny::IndexInfo, unsigned long long, const dtpb::VectorIndexFileProps &, void, void>' requested here
__alloc_traits::construct(this->__alloc(), _VSTD::__to_address(__tx.__pos_),
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:1706:9: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::__construct_one_at_end<unsigned long long, const dtpb::VectorIndexFileProps &>' requested here
__construct_one_at_end(_VSTD::forward<_Args>(__args)...);
^
/Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:243:26: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::emplace_back<unsigned long long, const dtpb::VectorIndexFileProps &>' requested here
index_infos->emplace_back(index_pb.index_page_id(), index_pb.vector_index());
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/construct_at.h:35:16: note: candidate template ignored: substitution failure [with _Tp = DB::DM::ColumnFileTiny::IndexInfo, _Args = <unsigned long long, const dtpb::VectorIndexFileProps &>]: no matching constructor for initialization of 'DB::DM::ColumnFileTiny::IndexInfo'
constexpr _Tp* construct_at(_Tp* __location, _Args&& ...__args) {
^
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:15:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Exception.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Logger.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/FmtUtils.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/compile.h:11:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/format.h:41:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/memory:673:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocation_guard.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocator_traits.h:298:9: error: no matching function for call to 'construct_at'
_VSTD::construct_at(__p, _VSTD::forward<_Args>(__args)...);
^~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:858:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_ABI_NAMESPACE
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:948:21: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<DB::DM::ColumnFileTiny::IndexInfo>>::construct<DB::DM::ColumnFileTiny::IndexInfo, unsigned long long, const std::nullopt_t &, void, void>' requested here
__alloc_traits::construct(this->__alloc(), _VSTD::__to_address(__tx.__pos_),
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:1706:9: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::__construct_one_at_end<unsigned long long, const std::nullopt_t &>' requested here
__construct_one_at_end(_VSTD::forward<_Args>(__args)...);
^
/Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:245:26: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::emplace_back<unsigned long long, const std::nullopt_t &>' requested here
index_infos->emplace_back(index_pb.index_page_id(), std::nullopt);
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/construct_at.h:35:16: note: candidate template ignored: substitution failure [with _Tp = DB::DM::ColumnFileTiny::IndexInfo, _Args = <unsigned long long, const std::nullopt_t &>]: no matching constructor for initialization of 'DB::DM::ColumnFileTiny::IndexInfo'
constexpr _Tp* construct_at(_Tp* __location, _Args&& ...__args) {
^
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:15:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Exception.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Logger.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/FmtUtils.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/compile.h:11:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/format.h:41:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/memory:673:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocation_guard.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocator_traits.h:298:9: error: no matching function for call to 'construct_at'
_VSTD::construct_at(__p, _VSTD::forward<_Args>(__args)...);
^~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:858:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_ABI_NAMESPACE
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:948:21: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<DB::DM::ColumnFileTiny::IndexInfo>>::construct<DB::DM::ColumnFileTiny::IndexInfo, unsigned long long &, const std::optional<dtpb::VectorIndexFileProps> &, void, void>' requested here
__alloc_traits::construct(this->__alloc(), _VSTD::__to_address(__tx.__pos_),
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:1706:9: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::__construct_one_at_end<unsigned long long &, const std::optional<dtpb::VectorIndexFileProps> &>' requested here
__construct_one_at_end(_VSTD::forward<_Args>(__args)...);
^
/Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:303:30: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::emplace_back<unsigned long long &, const std::optional<dtpb::VectorIndexFileProps> &>' requested here
new_index_infos->emplace_back(new_index_page_id, index.vector_index);
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/construct_at.h:35:16: note: candidate template ignored: substitution failure [with _Tp = DB::DM::ColumnFileTiny::IndexInfo, _Args = <unsigned long long &, const std::optional<dtpb::VectorIndexFileProps> &>]: no matching constructor for initialization of 'DB::DM::ColumnFileTiny::IndexInfo'
constexpr _Tp* construct_at(_Tp* __location, _Args&& ...__args) {
^
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:15:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Exception.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/Logger.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Common/FmtUtils.h:17:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/compile.h:11:
In file included from /Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/contrib/fmtlib-cmake/../fmtlib/include/fmt/format.h:41:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/memory:673:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocation_guard.h:14:
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/allocator_traits.h:298:9: error: no matching function for call to 'construct_at'
_VSTD::construct_at(__p, _VSTD::forward<_Args>(__args)...);
^~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__config:858:15: note: expanded from macro '_VSTD'
#define _VSTD std::_LIBCPP_ABI_NAMESPACE
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:948:21: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<DB::DM::ColumnFileTiny::IndexInfo>>::construct<DB::DM::ColumnFileTiny::IndexInfo, unsigned long long &, const std::nullopt_t &, void, void>' requested here
__alloc_traits::construct(this->__alloc(), _VSTD::__to_address(__tx.__pos_),
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/vector:1706:9: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::__construct_one_at_end<unsigned long long &, const std::nullopt_t &>' requested here
__construct_one_at_end(_VSTD::forward<_Args>(__args)...);
^
/Users/pingcap/workspace/bp-tiflash-release-darwin-arm64-6k7sx-build-binaries/source/tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp:305:30: note: in instantiation of function template specialization 'std::vector<DB::DM::ColumnFileTiny::IndexInfo>::emplace_back<unsigned long long &, const std::nullopt_t &>' requested here
new_index_infos->emplace_back(new_index_page_id, std::nullopt);
^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__memory/construct_at.h:35:16: note: candidate template ignored: substitution failure [with _Tp = DB::DM::ColumnFileTiny::IndexInfo, _Args = <unsigned long long &, const std::nullopt_t &>]: no matching constructor for initialization of 'DB::DM::ColumnFileTiny::IndexInfo'
constexpr _Tp* construct_at(_Tp* __location, _Args&& ...__args) {
^
4 errors generated.
make[3]: *** [dbms/src/Storages/DeltaMerge/CMakeFiles/delta_merge.dir/ColumnFile/
JaySon-Huang
approved these changes
Oct 21, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
approved these changes
Oct 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note