-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Support drop vector index defined on ColumnInfo when column is dropped #9475
Storage: Support drop vector index defined on ColumnInfo when column is dropped #9475
Conversation
Signed-off-by: Lloyd-Pottiger <[email protected]> Co-authored-by: JaySon <[email protected]>
f0c4859
to
5ca9f5b
Compare
Co-authored-by: JaySon <[email protected]>
std::size_t seed = 0; | ||
if (id.index_id > EmptyIndexID) | ||
{ | ||
hash_combine(seed, hash_value(0x01)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose to combine hash_value(0x01)
here and combine hash_value(0x02)
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To distinguish ComplexIndexID{1, 0}
and ComplexIndexID{0, 1}
Co-authored-by: jinhelin <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
3eb0c29
into
pingcap:feature/vector-index
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Pick https://github.com/tidbcloud/tiflash-cse/pull/283 and https://github.com/tidbcloud/tiflash-cse/pull/300
generateLocalIndexInfos
andinitLocalIndexInfos
Check List
Tests
Side effects
Documentation
Release note