-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disagg: Reduce the number of threads created for handling disaggregated requests #9335
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@JinheLin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #9334
Problem Summary:
In StorageDisaggregated, the call chain
buildReadTaskForWriteNode => buildReadTaskForWriteNodeTable => buildRNReadSegmentTask
will create aDynamicThreadManager
in each functions.The total number of threads used in
StorageDisaggregated
is aboutrequest_count * batch_cop_tasks.size() * resp.tables().size() * table.segments().size()
.What is changed and how it works?
If the number of tasks is greater than the number of threads,
DynamicThreadManager
will create new threads to handle these tasks, whileIOThreadPool
will make these tasks queue up.Check List
Tests
Side effects
Documentation
Release note