-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageStorage: Fix TiFlash may fail to restart after FAP is enabled #9319
PageStorage: Fix TiFlash may fail to restart after FAP is enabled #9319
Conversation
063f9b0
to
3058b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
after running for 45min |
/test pull-unit-test |
What problem does this PR solve?
Issue Number: close #9307
Problem Summary:
A RemotePage
The sequence that PageStorage see is
What is changed and how it works?
PageDirectory::updateLocalCacheForRemotePages
andPageDirectoryFactory::applyRecord
will callupdateLocalCacheForRemotePage
with ignore_delete=true when trying to update local cache of a RefPage (id_to_resolve != r.page_id
)Check List
Tests
Side effects
Documentation
Release note