-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coprocessor: Refactor encoding TiDBColumn
#9279
coprocessor: Refactor encoding TiDBColumn
#9279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
57c542e
into
pingcap:feature/vector-index
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
TiDBColumn::data
andTiDBColumn::finishAppendVar
should not be exposed as publicWhat is changed and how it works?
TiDBColumn::appendVectorF32
andColumnArray::getElementRef
to replace the origin implementationencodeLittleEndian
inTiDBColumn::appendVectorF32
instead of exception checkingCheck List
Tests
Side effects
Documentation
Release note