-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Support vector index and ANN hint #9261
storage: Support vector index and ANN hint #9261
Conversation
Signed-off-by: Wish <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
/build |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Co-authored-by: JaySon <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
#if 1 | ||
writeColumnStatToBuffer(tmp_buffer), | ||
#else | ||
// ExtendColumnStat is not enabled yet because it cause downgrade compatibility, wait | ||
// to be released with other binary format changes. | ||
writeExtendColumnStatToBuffer(tmp_buffer), | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaySon-Huang Please confirm those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm. It is OK because we need to bump the STORAGE_FORMAT_CURRENT
in later PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
32d911b
into
pingcap:feature/vector-index
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Pick https://github.com/tidbcloud/tiflash-cse/pull/156, https://github.com/tidbcloud/tiflash-cse/pull/162, https://github.com/tidbcloud/tiflash-cse/pull/163, https://github.com/tidbcloud/tiflash-cse/pull/164
Changes:
ExtendColumnStat
in DMFile meta for storing the meta of vector indexDMFileWriter::addStreams
will generate the index while writing down a new DMFileVectorIndex
generates the index by HNSW algorithmDMFileBlockInputStreamBuilder
will try to generate aDMFileWithVectorIndexBlockInputStream
. If vector index is unavailable, the read fallback to normal read and filter. InDMFileWithVectorIndexBlockInputStream
, itTODO:
tiflash/dbms/src/Storages/DeltaMerge/File/DMFileBlockInputStream.cpp
Lines 145 to 147 in 9fab7b2
Check List
Tests
Side effects
Documentation
Release note