Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add binaryDir to CMakePresets.json #9205

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jul 9, 2024

What problem does this PR solve?

Issue Number: close #8826

Problem Summary:

What is changed and how it works?


> ls cmake-build-coverage
ls: cannot access 'cmake-build-coverage': No such file or directory
> cmake --list-presets
Available configure presets:

  "dev"          - Development: DEBUG build with tests enabled
  "dev-coverage" - Development: DEBUG build with tests and code coverage enabled
  "release"      - Release: RELWITHDEBINFO build without tests enabled
  "asan"         - AddressSanitizer: ASAN build with tests enabled
  "tsan"         - ThreadSanitizer: TSAN build with tests enabled
  "benchmarks"   - Benchmarks: RELEASE build with benchmarks enabled
> cmake --preset=dev-coverage
Preset CMake variables:

  CMAKE_BUILD_TYPE="DEBUG"
  ENABLE_TESTS="ON"
  TEST_LLVM_COVERAGE="ON"
...

> ls cmake-build-coverage
build.ninja  CMakeCache.txt  CMakeFiles  cmake_install.cmake  compile_commands.json  contrib  CPackConfig.cmake  CPackSourceConfig.cmake  CTestTestfile.cmake  dbms  gens  include_directories.txt  libs
> 

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2024
@JaySon-Huang JaySon-Huang changed the title Add binaryDir to CMakePresets.json *: Add binaryDir to CMakePresets.json Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 05:33:09.169359627 +0000 UTC m=+335686.404593733: ☑️ agreed by JaySon-Huang.
  • 2024-07-09 07:26:31.555060544 +0000 UTC m=+342488.790294656: ☑️ agreed by JinheLin.

@JaySon-Huang
Copy link
Contributor

/test pull-unit-test

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 9, 2024

/retest

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 42f9c30 into pingcap:master Jul 9, 2024
5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-cmake-preset branch August 6, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better have cmake preset
4 participants