Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVStore: Temporarily disable reusing read index history #8980

Closed
wants to merge 2 commits into from

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Apr 23, 2024

What problem does this PR solve?

Issue Number: close #8845

Problem Summary:

According to #8845, we have to temporarily disable this mechanism before we find a way to address the current problem.

After this pr, we will expect more read index request being handled and processed by both TiFlash and TiKV. There could be some performance regressions, due to:

  1. More requests may heavy the burden of TiKV and TiFlash.
  2. Some single read index request could potentially processed slower, because it can't reuse history anymore.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from calvinneo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2024
@CalvinNeo CalvinNeo requested review from JaySon-Huang, solotzg and JinheLin and removed request for JaySon-Huang April 23, 2024 05:38
@CalvinNeo
Copy link
Member Author

/hold wait for another several round of regression tests

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

image

@CalvinNeo
Copy link
Member Author

This PR does not help

@CalvinNeo CalvinNeo closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiFlash result is not correct in consistency test
1 participant