Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVStore: Add some log for Learner Read #8979

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Apr 22, 2024

What problem does this PR solve?

Issue Number: ref #8845

Problem Summary:

Without this PR, we can't find correspondence between read index request and result.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2024
z
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo changed the title KVStore: Add some log for Learner Read [DNM] KVStore: Add some log for Learner Read Apr 22, 2024
@purelind
Copy link
Collaborator

/debug pull-integration-test

@purelind
Copy link
Collaborator

/debug pull-unit-test

z
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo changed the title [DNM] KVStore: Add some log for Learner Read KVStore: Add some log for Learner Read Apr 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 23, 2024
@JaySon-Huang
Copy link
Contributor

Can you describe why it cause the problem?

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Apr 23, 2024

Can you describe why it cause the problem?

This is not a bugfix(which will come after this PR). For root cause see the issue #8845.

@CalvinNeo CalvinNeo requested a review from JaySon-Huang April 23, 2024 04:13
@CalvinNeo
Copy link
Member Author

/run-all-tests

Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 03:36:14.843242998 +0000 UTC m=+58531.583145902: ☑️ agreed by JinheLin.
  • 2024-04-23 04:27:06.21118189 +0000 UTC m=+61582.951084799: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 3cd21c0 into pingcap:master Apr 23, 2024
6 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9004.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9007.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9009.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-6.5 from head ti-chi-bot:cherry-pick-8979-to-release-6.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID D0A6:289F7E:17E8EA7:2489541:6630483A and timestamp 2024-04-30 01:24:11 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits"}

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants