Fix AsyncTasks cancel deadlock #8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: CalvinNeo <[email protected]>
| LOG_INFO(Logger::get(), "Shutdown SharedContextDisagg"); | ||
| if (fap_context) | ||
| { | ||
| fap_context->shutdown(); |
There was a problem hiding this comment.
should we call fap_context.reset() after shutdown?
There was a problem hiding this comment.
I think it's not necessary. IMO, We don't need to eagerly reclaim the fap_context, we just need to eagerly join all workers in AsyncTasks.
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
approved these changes
Apr 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
Signed-off-by: CalvinNeo <[email protected]>
|
/run-all-tests |
ti-chi-bot
added
the
needs-cherry-pick-release-8.1
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Apr 18, 2024
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8952
Problem Summary:
See the details in #8952 (comment)
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note