Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: log region applied status when write #8932

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Storages: log region applied status when write #8932

merged 5 commits into from
Apr 11, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Apr 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8864

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
[2024/04/11 16:53:47.130 +08:00] [DEBUG] [DeltaMergeStore.cpp:567] ["region_id: 924121, applied_index: 1569337, record_count: 10, versions: {449006961195221023}"] [source="keyspace=4294967295 table_id=3009"] [thread_id=207]
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 10, 2024
@JinheLin JinheLin requested a review from CalvinNeo April 10, 2024 12:11
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2024
@JinheLin
Copy link
Contributor Author

/run-all-tests

JaySon-Huang
JaySon-Huang reviewed Apr 10, 2024
View reviewed changes
dbms/src/Core/Block.h Outdated Show resolved Hide resolved
@JinheLin JinheLin requested a review from JaySon-Huang April 11, 2024 04:28
@JinheLin
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2024
@JinheLin JinheLin changed the title Storages: log region id when write Storages: log region applied status when write Apr 11, 2024
@JinheLin JinheLin requested a review from CalvinNeo April 11, 2024 08:54
CalvinNeo
CalvinNeo approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 11, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-11 09:51:05.551493586 +0000 UTC m=+1128727.079034125: ☑️ agreed by CalvinNeo.
  • 2024-04-11 10:34:40.785121591 +0000 UTC m=+1131342.312662138: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 08c3ea1 into pingcap:master Apr 11, 2024
6 checks passed
@JinheLin JinheLin deleted the log_region_id branch April 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JinheLin @JaySon-Huang @CalvinNeo