KVStore: Fix test of async tasks #8928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
CalvinNeo
requested review from
JaySon-Huang and
Lloyd-Pottiger
and removed request for
JaySon-Huang
Comment on lines
+439
to
+443
| buffer.joinStr( | ||
| query_info.bypass_lock_ts->begin(), | ||
| query_info.bypass_lock_ts->end(), | ||
| [](const auto & v, FmtBuffer & f) { f.fmtAppend("{}", v); }, | ||
| "|"); |
There was a problem hiding this comment.
[v, v, v, ...] seems more clear?
There was a problem hiding this comment.
Why not fmt::format("{}", *bypass_lock_ts) directly.
There was a problem hiding this comment.
Elements of a vector/set will be enclosed by [].
Comment on lines
76
to
88
| FmtBuffer buffer; | ||
| buffer.append("ids="); | ||
| buffer.joinStr( | ||
| ids.begin(), | ||
| ids.end(), | ||
| [](const auto & v, FmtBuffer & f) { f.fmtAppend("{}", v); }, | ||
| "|"); | ||
| buffer.append(" locks="); | ||
| buffer.joinStr( | ||
| region_locks.begin(), | ||
| region_locks.end(), | ||
| [](const auto & v, FmtBuffer & f) { f.fmtAppend("{}({})", v.first, v.second->DebugString()); }, | ||
| "|"); |
There was a problem hiding this comment.
We can implement a fmt::formatter for std:: pair<RegionID, LockInfoPtr>, element type of region_locks. This way, this function can be simplified as follows:
fmt::format("ids={}, locks={}", ids, region_locks);
There was a problem hiding this comment.
Will fix it in later pr
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Lloyd-Pottiger
approved these changes
Apr 10, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/run-all-tests |
JinheLin
approved these changes
Apr 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
size/L
|
/run-all-tests |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Signed-off-by: CalvinNeo <[email protected]>
|
/run-all-tests |
|
|
/run-integration-test |
|
JaySon-Huang
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Apr 22, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8926
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note