Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: port some of delta-merge test into ut, part 1 #6160

Merged
merged 7 commits into from
Oct 24, 2022
Merged

Test: port some of delta-merge test into ut, part 1 #6160

merged 7 commits into from
Oct 24, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Oct 18, 2022

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 18, 2022

/run-all-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 18, 2022

I will port as much tests as the UT framework can.

JaySon-Huang
JaySon-Huang reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a great start!

I think tests/delta-merge-test/query/data_type can also be rewritten by current UT framework.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 18, 2022 •
edited
Loading

It is a great start!

I think tests/delta-merge-test/query/data_type can also be rewritten by current UT framework.

Yes, almost every tests in /delta-merge-test/query will be ported to UT.
In the porting process, I will make the UT framework easier to use.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 19, 2022

/run-all-tests

Lloyd-Pottiger
Lloyd-Pottiger approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@ywqzzy ywqzzy changed the title Test: port some of delta-merge test into ut. Test: port some of delta-merge test into ut, part 1 Oct 19, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 24, 2022

/run-all-tests

@ywqzzy ywqzzy requested a review from SeaRise October 24, 2022 06:30
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 24, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 24, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6e1b1e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 24, 2022
@ti-chi-bot ti-chi-bot merged commit bd29c38 into pingcap:master Oct 24, 2022
@ywqzzy ywqzzy mentioned this pull request Jan 4, 2023
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ywqzzy @ti-chi-bot @JaySon-Huang @SeaRise @Lloyd-Pottiger