Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: refine astToExecutor to ExecutorBinders #5915

Merged
merged 20 commits into from
Sep 22, 2022
Merged

Test: refine astToExecutor to ExecutorBinders #5915

merged 20 commits into from
Sep 22, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Separate Executor structs from astToExecutor to Binders. Rename executors to binders.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 16, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 16, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18758      8123             56.70%    217306  83359        61.64%

full coverage report (for internal network access only)

@ywqzzy ywqzzy changed the title [DNM]Test: refine astToExecutor to ExecutorBinders Test: refine astToExecutor to ExecutorBinders Sep 16, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2022
@ywqzzy ywqzzy marked this pull request as ready for review September 19, 2022 09:04
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 19, 2022

/run-all-tests

1 similar comment
@SeaRise
Copy link
Contributor

SeaRise commented Sep 19, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 19, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18863      8117             56.97%    219544  83598        61.92%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 19, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18863      8116             56.97%    219544  83581        61.93%

full coverage report (for internal network access only)

@ywqzzy ywqzzy force-pushed the astToExecutorToBinder branch from eb32b6e to 04893d3 Compare September 21, 2022 07:11
@xzhangxian1008
Copy link
Contributor

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 655a5d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18709      7922             57.66%    218342  81851        62.51%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18709      7922             57.66%    218342  81856        62.51%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/rebuild

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-integration-tests

1 similar comment
@SeaRise
Copy link
Contributor

SeaRise commented Sep 22, 2022

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 3d984da into pingcap:master Sep 22, 2022
@ywqzzy ywqzzy mentioned this pull request Oct 8, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@SeaRise SeaRise SeaRise approved these changes

@xzhangxian1008 xzhangxian1008 Awaiting requested review from xzhangxian1008

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ywqzzy @ti-chi-bot @sre-bot @SeaRise @xzhangxian1008 @Lloyd-Pottiger