Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Refine astToExecutor #5895

Merged
merged 14 commits into from
Sep 15, 2022
Merged

Test: Refine astToExecutor #5895

merged 14 commits into from
Sep 15, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 15, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Move astToExecutor to MockExecutor folder.
Extract utils from astToExecutor

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 15, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 15, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockExecutor/astToExecutor.cpp              594               129    78.28%          49                 2    95.92%        1587               338    78.70%         604               175    71.03%
Debug/MockExecutor/astToExecutor.h                 30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Debug/MockExecutor/astToExecutorUtils.cpp          15                 2    86.67%           5                 1    80.00%          49                 7    85.71%          14                 1    92.86%
Debug/dbgFuncCoprocessor.cpp                      441               329    25.40%          46                30    34.78%         936               636    32.05%         296               225    23.99%
Debug/dbgFuncCoprocessor.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/ColumnsToTiPBExpr.cpp                    55                 5    90.91%           6                 0   100.00%         124                12    90.32%          40                 7    82.50%
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         290                24    91.72%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            1224               480    60.78%         187                42    77.54%        3067              1035    66.25%         996               415    58.33%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18746      8127             56.65%    217122  83546        61.52%

full coverage report (for internal network access only)

@ywqzzy ywqzzy requested a review from SeaRise September 15, 2022 05:25
SeaRise
SeaRise approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2022
LittleFall
LittleFall approved these changes Sep 15, 2022
View reviewed changes
dbms/src/Debug/MockExecutor/funcSigs.h Outdated Show resolved Hide resolved
dbms/src/Debug/MockExecutor/astToExecutorUtils.h Outdated Show resolved Hide resolved
dbms/src/Debug/MockExecutor/astToExecutorUtils.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c7c7a8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 15, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockExecutor/astToExecutor.cpp              594               129    78.28%          49                 2    95.92%        1587               338    78.70%         604               175    71.03%
Debug/MockExecutor/astToExecutor.h                 30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Debug/MockExecutor/astToExecutorUtils.cpp          15                 2    86.67%           5                 1    80.00%          49                 7    85.71%          14                 1    92.86%
Debug/dbgFuncCoprocessor.cpp                      441               329    25.40%          46                30    34.78%         936               636    32.05%         296               225    23.99%
Debug/dbgFuncCoprocessor.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/ColumnsToTiPBExpr.cpp                    55                 5    90.91%           6                 0   100.00%         124                12    90.32%          40                 7    82.50%
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         290                24    91.72%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            1224               480    60.78%         187                42    77.54%        3067              1035    66.25%         996               415    58.33%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18750      8129             56.65%    217175  83507        61.55%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 15, 2022

/run-integration-tests

@SeaRise
Copy link
Contributor

SeaRise commented Sep 15, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 15, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockExecutor/astToExecutor.cpp              594               129    78.28%          49                 2    95.92%        1587               338    78.70%         604               175    71.03%
Debug/MockExecutor/astToExecutor.h                 30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Debug/MockExecutor/astToExecutorUtils.cpp          15                 2    86.67%           5                 1    80.00%          49                 7    85.71%          14                 1    92.86%
Debug/dbgFuncCoprocessor.cpp                      441               329    25.40%          46                30    34.78%         936               636    32.05%         296               225    23.99%
Debug/dbgFuncCoprocessor.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/ColumnsToTiPBExpr.cpp                    55                 5    90.91%           6                 0   100.00%         124                12    90.32%          40                 7    82.50%
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         290                24    91.72%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            1224               480    60.78%         187                42    77.54%        3067              1035    66.25%         996               415    58.33%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18748      8129             56.64%    217171  83493        61.55%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 15, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 15, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockExecutor/astToExecutor.cpp              594               129    78.28%          49                 2    95.92%        1587               338    78.70%         604               175    71.03%
Debug/MockExecutor/astToExecutor.h                 30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Debug/MockExecutor/astToExecutorUtils.cpp          15                 2    86.67%           5                 1    80.00%          49                 7    85.71%          14                 1    92.86%
Debug/dbgFuncCoprocessor.cpp                      441               329    25.40%          46                30    34.78%         936               636    32.05%         296               225    23.99%
Debug/dbgFuncCoprocessor.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/ColumnsToTiPBExpr.cpp                    55                 5    90.91%           6                 0   100.00%         124                12    90.32%          40                 7    82.50%
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         290                24    91.72%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            1224               480    60.78%         187                42    77.54%        3067              1035    66.25%         996               415    58.33%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18758      8125             56.69%    217306  83475        61.59%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5ddccf4 into pingcap:master Sep 15, 2022
@ywqzzy ywqzzy mentioned this pull request Oct 8, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@LittleFall LittleFall LittleFall approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ywqzzy @ti-chi-bot @sre-bot @SeaRise @LittleFall @Lloyd-Pottiger