support tiflash_fastscan variable from tidb, remove fast mode in table_info, and change name fast mode to fast scan #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
needs-rebase
|
/run-all-tests |
|
/rebuild |
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/cc @breezewish |
hongyunyan
changed the title
|
/run-all-tests |
|
/rebuild |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/cc @lidezhu |
breezewish
reviewed
Aug 30, 2022
breezewish
reviewed
Aug 30, 2022
|
|
||
| mysql> alter table test.t compact tiflash replica; | ||
|
|
||
| mysql> set @@tiflash_fastscan=ON; set session tidb_isolation_read_engines='tiflash'; select * from test.t; |
There was a problem hiding this comment.
Is it possible to test multiple sessions? For example, if you incorrectly implemented this session variable to be effective globally, this test case will still pass.
There was a problem hiding this comment.
Yes, I add more comprehensive test cases here.
breezewish
approved these changes
Aug 30, 2022
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
lidezhu
reviewed
Aug 30, 2022
|
/run-all-tests |
|
/run-all-tests |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 7c48b19
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #5252
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note