feat: do del column clean read optimization for fast mode #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
/run-all-tests |
…yunyan_fast_mode_enable_del_index
hongyunyan
changed the title
ti-chi-bot
added
the
do-not-merge/work-in-progress
…yunyan_fast_mode_enable_del_index
ti-chi-bot
added
size/XL
ti-chi-bot
added
size/XXL
ti-chi-bot
removed
the
needs-rebase
hongyunyan
changed the title
ti-chi-bot
removed
the
do-not-merge/work-in-progress
…yunyan_fast_mode_enable_del_index
|
/run-all-tests |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ti-chi-bot
added
size/XL
|
/run-all-tests |
|
/rebuild |
|
/run-integration-test |
|
/rebuild |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-integration-test |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: b08aba1
|
ti-chi-bot
added
the
status/can-merge
|
@hongyunyan: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #5252
Problem Summary:
For the query in fast mode, we always read the del_mark column, and then do filter with del_mark = 1. While for the packs that all rows' del_mark = 0, we don't need to read their del_mark column, and also don't need to do the filter with del_mark. Thus we add these optimization to cut down IO.
Now, some code is just for benchmark test(bench_del_optimization). After the review, I will delete the related codes.
What is changed and how it works?
performance test：
I run the bench_del_optimization benchmark(to compare the performance with/without del optimization to read a dmfile with no delete rows) , the performance is
Besides，I run the dtworkload, and the total performance is almost the same.
Check List
Tests
Side effects
Documentation
Release note